torsten/yourpart3
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(vocab): reject lexical hints paired with sentences

Browse Source
This commit is contained in:
Torsten Schulz (local)
2026-08-27 12:25:43 +02:00
parent c836c709c4
commit d9397f741f
4 changed files with 37 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
backend/migrations-active/20260827000000-remove-invalid-karon-srs-card.cjs Normal file
View File

@@ -0,0 +1,17 @@
'use strict';
module.exports = {
async up(queryInterface) {
// A legacy gap-fill hint was persisted as a vocabulary answer. The pair
// "jetzt/heute" → "Karon naa ko diri" is not a valid translation card.
await queryInterface.sequelize.query(`
DELETE FROM community.vocab_srs_item
WHERE lower(trim(learning)) = 'jetzt/heute'
AND lower(trim(reference)) = 'karon naa ko diri';
`);
},
async down() {
// Do not restore an invalid study card.
}
};

9
backend/services/vocabService.js
View File

@@ -201,8 +201,15 @@ export default class VocabService {
const rightLooksSentence = rightWords >= 3 || /[?!.].+\S/.test(rightText);
const leftLooksShortFragment = leftWords <= 1 && leftText.length <= 12;
const rightLooksShortFragment = rightWords <= 1 && rightText.length <= 12;
// A slash-separated hint such as "jetzt/heute" is a lexical alternative,
// never the translation of a full sentence such as "Karon naa ko diri".
const leftLooksLexicalHint = /\//.test(leftText) && leftWords <= 2 && leftText.length <= 24;
const rightLooksLexicalHint = /\//.test(rightText) && rightWords <= 2 && rightText.length <= 24;
return (leftLooksShortFragment && rightLooksSentence) || (rightLooksShortFragment && leftLooksSentence);
return (leftLooksShortFragment && rightLooksSentence)
|| (rightLooksShortFragment && leftLooksSentence)
|| (leftLooksLexicalHint && rightLooksSentence)
|| (rightLooksLexicalHint && leftLooksSentence);
}
_calculateSrsSchedule(item, { correct } = {}) {

7
frontend/src/dialogues/socialnetwork/VocabPracticeDialog.vue
View File

@@ -739,8 +739,13 @@ export default {
const rightLooksSentence = rightWords >= 3 || /[?!.].+\S/.test(rightText);
const leftLooksShortFragment = leftWords <= 1 && leftText.length <= 12;
const rightLooksShortFragment = rightWords <= 1 && rightText.length <= 12;
const leftLooksLexicalHint = /\//.test(leftText) && leftWords <= 2 && leftText.length <= 24;
const rightLooksLexicalHint = /\//.test(rightText) && rightWords <= 2 && rightText.length <= 24;
return (leftLooksShortFragment && rightLooksSentence) || (rightLooksShortFragment && leftLooksSentence);
return (leftLooksShortFragment && rightLooksSentence)
|| (rightLooksShortFragment && leftLooksSentence)
|| (leftLooksLexicalHint && rightLooksSentence)
|| (rightLooksLexicalHint && leftLooksSentence);
},
splitPhraseAlternatives(value) {
const text = String(value || '').trim();

7
frontend/src/views/social/VocabLessonView.vue
View File

@@ -2320,8 +2320,13 @@ export default {
const rightLooksSentence = rightWords >= 3 || /[?!.].+\S/.test(rightText);
const leftLooksShortFragment = leftWords <= 1 && leftText.length <= 12;
const rightLooksShortFragment = rightWords <= 1 && rightText.length <= 12;
const leftLooksLexicalHint = /\//.test(leftText) && leftWords <= 2 && leftText.length <= 24;
const rightLooksLexicalHint = /\//.test(rightText) && rightWords <= 2 && rightText.length <= 24;
return (leftLooksShortFragment && rightLooksSentence) || (rightLooksShortFragment && leftLooksSentence);
return (leftLooksShortFragment && rightLooksSentence)
|| (rightLooksShortFragment && leftLooksSentence)
|| (leftLooksLexicalHint && rightLooksSentence)
|| (rightLooksLexicalHint && leftLooksSentence);
},
isTrainableLessonVocabPair(learning, reference) {
const l = String(learning || '').trim();