refactor(clubSettings): remove myTischtennis club ID and update related logic

- Removed the myTischtennis club ID field from club settings and related backend logic.
- Updated the database migration to eliminate the my_tischtennis_club_id column.
- Adjusted frontend components and services to reflect the removal of the club ID, ensuring the use of association member number instead.
- Enhanced user interface hints to clarify the use of association member number for rankings.
This commit is contained in:
Torsten Schulz (local)
2026-03-12 10:34:10 +01:00
parent ad09a45b17
commit a030e07b46
7 changed files with 9 additions and 28 deletions

View File

@@ -60,11 +60,10 @@ export const updateClubSettings = async (req, res) => {
try {
const { authcode: token } = req.headers;
const { clubid } = req.params;
const { greetingText, associationMemberNumber, myTischtennisClubId, myTischtennisFedNickname, autoFetchRankings } = req.body;
const { greetingText, associationMemberNumber, myTischtennisFedNickname, autoFetchRankings } = req.body;
const updated = await ClubService.updateClubSettings(token, clubid, {
greetingText,
associationMemberNumber,
myTischtennisClubId,
myTischtennisFedNickname,
autoFetchRankings
});

View File

@@ -1,9 +1,8 @@
-- Migration: Add myTischtennis rankings settings to clubs table
-- Enables per-club configuration of TTR/QTTR rankings fetch (club ID, federation, enable flag)
-- Enables per-club configuration of TTR/QTTR rankings fetch.
-- Club number comes from association_member_number (Verbands-Mitgliedsnummer).
ALTER TABLE clubs
ADD COLUMN IF NOT EXISTS my_tischtennis_club_id VARCHAR(50) NULL
COMMENT 'myTischtennis club number for rankings (e.g. 43030)',
ADD COLUMN IF NOT EXISTS my_tischtennis_fed_nickname VARCHAR(50) NULL
COMMENT 'Federation short name for rankings (e.g. HeTTV)',
ADD COLUMN IF NOT EXISTS auto_fetch_rankings BOOLEAN NOT NULL DEFAULT FALSE

View File

@@ -17,12 +17,6 @@ const Club = sequelize.define('Club', {
allowNull: true,
field: 'association_member_number'
},
myTischtennisClubId: {
type: DataTypes.STRING,
allowNull: true,
field: 'my_tischtennis_club_id',
comment: 'myTischtennis club number for rankings (e.g. 43030)'
},
myTischtennisFedNickname: {
type: DataTypes.STRING,
allowNull: true,

View File

@@ -70,7 +70,6 @@ class ClubService {
async updateClubSettings(userToken, clubId, {
greetingText,
associationMemberNumber,
myTischtennisClubId,
myTischtennisFedNickname,
autoFetchRankings
}) {
@@ -80,7 +79,6 @@ class ClubService {
throw new Error('clubnotfound');
}
const updates = { greetingText, associationMemberNumber };
if (myTischtennisClubId !== undefined) updates.myTischtennisClubId = myTischtennisClubId || null;
if (myTischtennisFedNickname !== undefined) updates.myTischtennisFedNickname = myTischtennisFedNickname || null;
if (autoFetchRankings !== undefined) updates.autoFetchRankings = !!autoFetchRankings;
return await club.update(updates);

View File

@@ -396,14 +396,14 @@ class MemberService {
};
}
const effectiveClubId = (club.myTischtennisClubId || '').trim() || account.clubId;
const effectiveClubId = (club.associationMemberNumber || '').trim() || account.clubId;
const effectiveFedNickname = (club.myTischtennisFedNickname || '').trim() || account.fedNickname;
if (!effectiveClubId || !effectiveFedNickname) {
console.error('[updateRatingsFromMyTischtennis] - Missing clubId or fedNickname:', {
clubId: effectiveClubId,
fedNickname: effectiveFedNickname,
fromClub: !!(club.myTischtennisClubId && club.myTischtennisFedNickname)
fromClub: !!(club.associationMemberNumber && club.myTischtennisFedNickname)
});
return {
status: 400,

View File

@@ -741,10 +741,9 @@
"myTischtennisRankings": "myTischtennis TTR/QTTR-Ranglisten",
"myTischtennisRankingsHint": "Automatischer Abruf der Vereins-Rangliste für TTR- und QTTR-Updates der Mitglieder.",
"autoFetchRankings": "Ranglisten automatisch abrufen",
"myTischtennisClubId": "myTischtennis Vereinsnummer",
"myTischtennisClubIdPlaceholder": "z. B. 43030",
"myTischtennisFedNickname": "Verbandskürzel",
"myTischtennisFedNicknamePlaceholder": "z. B. HeTTV"
"myTischtennisFedNicknamePlaceholder": "z. B. HeTTV",
"rankingsUsesAssociationNumber": "Die Vereinsnummer für den Ranglisten-Abruf entspricht der Verbands-Mitgliedsnummer oben."
},
"predefinedActivities": {
"title": "Vordefinierte Aktivitäten",

View File

@@ -61,15 +61,12 @@
</label>
</div>
<div v-if="autoFetchRankings" class="rankings-fields">
<div class="field-group">
<label>{{ $t('clubSettings.myTischtennisClubId') }}</label>
<input v-model="myTischtennisClubId" class="text-input" :placeholder="$t('clubSettings.myTischtennisClubIdPlaceholder')" />
</div>
<div class="field-group">
<label>{{ $t('clubSettings.myTischtennisFedNickname') }}</label>
<input v-model="myTischtennisFedNickname" class="text-input" :placeholder="$t('clubSettings.myTischtennisFedNicknamePlaceholder')" />
</div>
</div>
<p v-if="autoFetchRankings" class="hint">{{ $t('clubSettings.rankingsUsesAssociationNumber') }}</p>
</section>
<section v-if="currentClub && !loading" class="card actions-card">
@@ -112,7 +109,6 @@ export default {
activeTab: 'settings',
greeting: '',
associationMemberNumber: '',
myTischtennisClubId: '',
myTischtennisFedNickname: '',
autoFetchRankings: false,
saved: false,
@@ -136,7 +132,6 @@ export default {
if (!this.currentClub) {
this.greeting = '';
this.associationMemberNumber = '';
this.myTischtennisClubId = '';
this.myTischtennisFedNickname = '';
this.autoFetchRankings = false;
this.loadError = null;
@@ -149,14 +144,12 @@ export default {
const club = response.data;
this.greeting = club?.greetingText ?? '';
this.associationMemberNumber = club?.associationMemberNumber ?? '';
this.myTischtennisClubId = club?.myTischtennisClubId ?? '';
this.myTischtennisFedNickname = club?.myTischtennisFedNickname ?? '';
this.autoFetchRankings = !!club?.autoFetchRankings;
} catch (e) {
this.loadError = this.$t('clubSettings.loadFailed');
this.greeting = '';
this.associationMemberNumber = '';
this.myTischtennisClubId = '';
this.myTischtennisFedNickname = '';
this.autoFetchRankings = false;
} finally {
@@ -172,7 +165,6 @@ export default {
await apiClient.put(`/clubs/${this.currentClub}/settings`, {
greetingText: this.greeting,
associationMemberNumber: this.associationMemberNumber,
myTischtennisClubId: this.myTischtennisClubId || null,
myTischtennisFedNickname: this.myTischtennisFedNickname || null,
autoFetchRankings: this.autoFetchRankings,
});
@@ -211,7 +203,7 @@ export default {
}
.text-input { width: 100%; border: 1px solid #ddd; border-radius: 6px; padding: 8px; font-size: 14px; }
.rankings-row { margin-bottom: 12px; }
.rankings-fields { display: grid; grid-template-columns: 1fr 1fr; gap: 16px; margin-top: 12px; }
.rankings-fields { margin-top: 12px; }
.field-group label { display: block; margin-bottom: 4px; font-weight: 500; color: #333; }
.checkbox-label { display: flex; align-items: center; gap: 8px; cursor: pointer; }
.checkbox-label input[type="checkbox"] { width: auto; }