torsten/trainingstagebuch
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

refactor(DiaryView): streamline activity posting logic by consolidating group handling
All checks were successful
Deploy tt-tagebuch / deploy (push) Successful in 43s
Details

Browse Source 
- Simplified the logic for posting activities by reducing the number of API calls when a group is selected.
- Updated the handling of `groupId` to ensure it is set correctly based on the selected group filter, improving code clarity and maintainability.
This commit is contained in:
Torsten Schulz (local)
2026-05-08 13:57:31 +02:00
parent 2b16cdff53
commit 808493c06e
1 changed files with 13 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
frontend/src/views/DiaryView.vue
View File

@@ -2334,33 +2334,19 @@ export default {
return;
}
if (!this.addNewTimeblock && (this.groups || []).length > 0) {
const targetGroupIds = this.planGroupFilter !== '__all__'
? [Number(this.planGroupFilter)]
: this.groups.map((g) => Number(g.id)).filter((id) => Number.isFinite(id));
if (targetGroupIds.length > 0) {
for (const groupId of targetGroupIds) {
await apiClient.post(`/diary-date-activities/${this.currentClub}`, {
diaryDateId: this.date.id,
activity: this.newPlanItem.activity,
predefinedActivityId: this.newPlanItem.predefinedActivityId,
isTimeblock: false,
duration: this.newPlanItem.duration,
durationText: this.newPlanItem.durationText,
groupId,
orderId: this.trainingPlan.length
});
}
} else {
await apiClient.post(`/diary-date-activities/${this.currentClub}`, {
diaryDateId: this.date.id,
activity: this.newPlanItem.activity,
predefinedActivityId: this.newPlanItem.predefinedActivityId,
isTimeblock: false,
duration: this.newPlanItem.duration,
durationText: this.newPlanItem.durationText,
orderId: this.trainingPlan.length
});
}
const selectedGroupId = this.planGroupFilter !== '__all__'
? Number(this.planGroupFilter)
: null;
await apiClient.post(`/diary-date-activities/${this.currentClub}`, {
diaryDateId: this.date.id,
activity: this.newPlanItem.activity,
predefinedActivityId: this.newPlanItem.predefinedActivityId,
isTimeblock: false,
duration: this.newPlanItem.duration,
durationText: this.newPlanItem.durationText,
groupId: Number.isFinite(selectedGroupId) ? selectedGroupId : null,
orderId: this.trainingPlan.length
});
} else {
await apiClient.post(`/diary-date-activities/${this.currentClub}`, {
diaryDateId: this.date.id,