torsten/yourpart3
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor native language filtering in VocabService and update frontend handling

Browse Source 
- Simplified the logic for filtering courses by native language in VocabService, allowing for better handling of undefined and null values.
- Enhanced the VocabCourseListView to clarify the behavior of nativeLanguageId based on user selection, ensuring accurate course retrieval based on language preferences.
- Improved comments in both files for better understanding of the filtering logic and its implications on course visibility.
This commit is contained in:
Torsten Schulz (local)
2026-01-19 12:09:48 +01:00
parent ddd038761b
commit f902f5298c
2 changed files with 19 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
backend/services/vocabService.js
View File

@@ -586,14 +586,13 @@ export default class VocabService {
}
// Filter nach Muttersprache (die Sprache des Lerners)
if (nativeLanguageId !== undefined) {
if (nativeLanguageId === null) {
// NULL bedeutet "für alle Sprachen" - zeige Kurse ohne native_language_id
where.nativeLanguageId = null;
} else {
where.nativeLanguageId = Number(nativeLanguageId);
}
// Wenn nativeLanguageId nicht gesetzt ist (undefined), zeige alle Kurse (kein Filter)
// Wenn nativeLanguageId === null oder 'null' (aus Frontend), zeige alle Kurse (kein Filter)
// Wenn nativeLanguageId eine Zahl ist, zeige nur Kurse für diese Muttersprache
if (nativeLanguageId !== undefined && nativeLanguageId !== null && nativeLanguageId !== 'null') {
where.nativeLanguageId = Number(nativeLanguageId);
}
// Wenn nativeLanguageId null/undefined/'null' ist, wird kein Filter angewendet = alle Kurse
// Suche nach Titel oder Beschreibung
if (search && search.trim()) {