torsten/yourpart3
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor user house retrieval in FalukantService: Update logic to check for user ID before querying UserHouse, preventing unnecessary database calls and improving error handling. Maintain separate queries for UserHouse and relationships to avoid EagerLoadingError.

Browse Source
This commit is contained in:
Torsten Schulz (local)
2026-02-04 14:20:22 +01:00
parent d038d72cde
commit bbc3354f16
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
backend/services/falukantService.js
View File

@@ -406,14 +406,17 @@ class FalukantService extends BaseService {
] ]
}, },
], ],
attributes: ['money', 'creditAmount', 'todayCreditTaken',] attributes: ['id', 'money', 'creditAmount', 'todayCreditTaken']
}); });
if (!u) throw new Error('User not found'); if (!u) throw new Error('User not found');
// Load UserHouse and HouseType in separate queries to avoid EagerLoadingError // Load UserHouse and HouseType in separate queries to avoid EagerLoadingError
const userHouse = await UserHouse.findOne({ let userHouse = null;
where: { userId: u.id }, if (u.id != null) {
attributes: ['roofCondition', 'houseTypeId'] userHouse = await UserHouse.findOne({
}); where: { userId: u.id },
attributes: ['roofCondition', 'houseTypeId']
});
}
if (userHouse?.houseTypeId) { if (userHouse?.houseTypeId) {
const houseType = await HouseType.findOne({ const houseType = await HouseType.findOne({
where: { id: userHouse.houseTypeId }, where: { id: userHouse.houseTypeId },