torsten/yourpart3
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor effect handling in enrichNotificationsWithCharacterNames to improve data parsing

Browse Source 
- Simplified the logic for processing notification effects by consolidating the JSON parsing into a single conditional check, enhancing code readability and maintainability.
- Ensured consistent handling of effects regardless of their initial format, improving robustness in notification enrichment.
This commit is contained in:
Torsten Schulz (local)
2026-01-15 09:28:00 +01:00
parent ba469ef900
commit b706191a0e
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
backend/services/falukantService.js
View File

@@ -5969,7 +5969,10 @@ async function enrichNotificationsWithCharacterNames(notifications) {
// parse n.effects if present // parse n.effects if present
try { try {
if (n.effects) { if (n.effects) {
const eff = typeof n.effects === 'string' && n.effects.trim().startsWith('{') ? JSON.parse(n.effects) : n.effects; let eff = n.effects;
if (typeof eff === 'string') {
eff = JSON.parse(eff);
}
collectIds(eff); collectIds(eff);
} }
} catch (err) { /* ignore */ } } catch (err) { /* ignore */ }
@@ -6037,7 +6040,10 @@ async function enrichNotificationsWithCharacterNames(notifications) {
try { try {
if (n.effects) { if (n.effects) {
const eff = typeof n.effects === 'string' && n.effects.trim().startsWith('{') ? JSON.parse(n.effects) : n.effects; let eff = n.effects;
if (typeof eff === 'string') {
eff = JSON.parse(eff);
}
foundId = findFirstId(eff) || foundId; foundId = findFirstId(eff) || foundId;
} }
} catch (err) { /* ignore */ } } catch (err) { /* ignore */ }