feat(falukant): optimize retrieval of not baptized children by using character IDs

backend/services/falukantService.js

@@ -5855,24 +5855,14 @@ class FalukantService extends BaseService {
 
     async getNotBaptisedChildren(hashedUserId) {
         const falukantUser = await getFalukantUserOrFail(hashedUserId);
+        const userCharacterIds = (await FalukantCharacter.findAll({
+            where: { userId: falukantUser.id },
+            attributes: ['id'],
+            raw: true,
+        })).map((character) => character.id);
+        if (userCharacterIds.length === 0) return [];
         const children = await ChildRelation.findAll({
             include: [
-                {
-                    model: FalukantCharacter,
-                    as: 'father',
-                    where: {
-                        userId: falukantUser.id,
-                    },
-                    required: false,
-                },
-                {
-                    model: FalukantCharacter,
-                    as: 'mother',
-                    where: {
-                        userId: falukantUser.id,
-                    },
-                    required: false,
-                },
                 {
                     model: FalukantCharacter,
                     as: 'child',
@@ -5888,6 +5878,10 @@ class FalukantService extends BaseService {
             ],
             where: {
                 nameSet: false,
+                [Op.or]: [
+                    { fatherCharacterId: { [Op.in]: userCharacterIds } },
+                    { motherCharacterId: { [Op.in]: userCharacterIds } },
+                ],
             },
             order: [['createdAt', 'DESC']],
         });