From 4cce0441280e18178d727d6cedc839a8a720edb4 Mon Sep 17 00:00:00 2001
From: "Torsten Schulz (local)" <tsschulz@gmx.net>
Date: Thu, 29 Jan 2026 07:46:17 +0100
Subject: [PATCH] Refactor character name handling in
 enrichNotificationsWithCharacterNames: Update comments for clarity on
 character_name and characterName usage. Enhance localization by adding
 success messages in German and English translations.

---
 backend/services/falukantService.js       | 4 ++--
 frontend/src/i18n/locales/de/message.json | 3 ++-
 frontend/src/i18n/locales/en/message.json | 3 ++-
 3 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/backend/services/falukantService.js b/backend/services/falukantService.js
index da828df..ecb9f15 100644
--- a/backend/services/falukantService.js
+++ b/backend/services/falukantService.js
@@ -5514,7 +5514,7 @@ async function enrichNotificationsWithCharacterNames(notifications) {
         return null;
     }
 
-    // Attach resolved name to notifications (set both characterName and character_name)
+    // Attach resolved name to notifications (set character_name; characterName is a getter that reads from it)
     for (const n of notifications) {
         let foundId = null;
         try {
@@ -5536,7 +5536,7 @@ async function enrichNotificationsWithCharacterNames(notifications) {
 
         if (foundId && nameMap.has(Number(foundId))) {
             const resolved = nameMap.get(Number(foundId));
-            n.characterName = resolved;
+            // Set character_name directly (characterName is a getter that reads from character_name)
             n.character_name = resolved;
         }
     }
diff --git a/frontend/src/i18n/locales/de/message.json b/frontend/src/i18n/locales/de/message.json
index 993f528..909c567 100644
--- a/frontend/src/i18n/locales/de/message.json
+++ b/frontend/src/i18n/locales/de/message.json
@@ -2,6 +2,7 @@
   "message": {
     "title": "Mitteilung",
     "close": "Schließen",
-    "test": "Test funktioniert"
+    "test": "Test funktioniert",
+    "success": "Die Aktion war erfolgreich."
   }
 }
diff --git a/frontend/src/i18n/locales/en/message.json b/frontend/src/i18n/locales/en/message.json
index 8df2c14..06b1ed8 100644
--- a/frontend/src/i18n/locales/en/message.json
+++ b/frontend/src/i18n/locales/en/message.json
@@ -1,6 +1,7 @@
 {
   "message": {
     "title": "Notice",
-    "close": "Close"
+    "close": "Close",
+    "success": "The action was successful."
   }
 }