From 8db82e0cedb72a99ee6cfa3341f21357f556288e Mon Sep 17 00:00:00 2001 From: "Torsten Schulz (local)" Date: Fri, 5 Dec 2025 14:20:56 +0100 Subject: [PATCH] Refactor transport planning in DirectorWorker: Updated variable naming for clarity by changing 'shipped' to '_shipped' to indicate unused variable. Removed unused get_branch_user_id function from TransportWorker to streamline code and improve maintainability. --- src/worker/director.rs | 2 +- src/worker/transport.rs | 24 ------------------------ 2 files changed, 1 insertion(+), 25 deletions(-) diff --git a/src/worker/director.rs b/src/worker/director.rs index f45c75d..aa03923 100644 --- a/src/worker/director.rs +++ b/src/worker/director.rs @@ -930,7 +930,7 @@ impl DirectorWorker { // - Inventar-Mengen reduziert (geschieht bereits in plan_transports_for_item) // Die zurückgegebenen Mengen werden dann lokal verkauft. for item in items.iter_mut() { - let shipped = self.plan_transports_for_item( + let _shipped = self.plan_transports_for_item( &mut conn, falukant_user_id, item, diff --git a/src/worker/transport.rs b/src/worker/transport.rs index a32afd6..b787525 100644 --- a/src/worker/transport.rs +++ b/src/worker/transport.rs @@ -492,30 +492,6 @@ impl TransportWorker { Ok(()) } - fn get_branch_user_id(pool: &ConnectionPool, branch_id: i32) -> Result { - let mut conn = pool - .get() - .map_err(|e| DbError::new(format!("DB-Verbindung fehlgeschlagen: {e}")))?; - - const QUERY_GET_BRANCH_USER: &str = r#" - SELECT falukant_user_id - FROM falukant_data.branch - WHERE id = $1 - LIMIT 1; - "#; - - conn.prepare("get_branch_user", QUERY_GET_BRANCH_USER)?; - let rows = conn.execute("get_branch_user", &[&branch_id])?; - - let user_id = rows - .get(0) - .and_then(|r| r.get("falukant_user_id")) - .and_then(|v| v.parse::().ok()) - .unwrap_or(-1); - - Ok(user_id) - } - fn insert_transport_waiting_notification( pool: &ConnectionPool, user_id: i32,