Refactor money change action string in EventsWorker: Simplify the action string for money history by differentiating between positive and negative changes. Remove unnecessary parameters from the function signature to enhance clarity and maintainability.

This commit is contained in:
Torsten Schulz (local)
2026-01-12 16:38:38 +01:00
parent 408221ffb4
commit 5f55aeea99

View File

@@ -1162,8 +1162,6 @@ impl EventsWorker {
conn: &mut DbConnection,
user_id: i32,
percent_change: f64,
_event_id: &str,
event_title: &str,
) -> Result<f64, DbError> {
// Hole aktuelles Geld
conn.prepare("get_money", QUERY_GET_MONEY)?;
@@ -1183,8 +1181,12 @@ impl EventsWorker {
};
let change = current_money * (percent_change / 100.0);
// Spezifischer action-String für money history (z.B. "Zufallsereignis: Unerwarteter Geldsegen")
let action = format!("Zufallsereignis: {}", event_title);
// Action-String für money history: Unterscheide zwischen positiven (Geldsegen) und negativen (Diebstahl) Änderungen
let action = if percent_change > 0.0 {
"Zufallsereignis: Unerwarteter Geldsegen"
} else {
"Zufallsereignis: Diebstahl"
};
// Verwende parametrisierte Queries für Sicherheit gegen SQL-Injection
conn.prepare("update_money_event", QUERY_UPDATE_MONEY)?;