Enhance error handling and logging in backend controllers and services

This commit improves error handling in various controllers, including diaryNoteController, memberNoteController, and permissionController, by adding console error logging for better debugging. Additionally, it updates the diaryService and teamDocumentService to enhance functionality and maintainability. The config.js file is also updated to ensure proper configuration for the development environment. These changes contribute to a more robust and user-friendly application.

backend/controllers/diaryNoteController.js

@@ -29,14 +29,17 @@ export const createNote = async (req, res) => {
         if (Array.isArray(tags) && tags.length > 0 && typeof newNote.addTags === 'function') {
             const tagInstances = await DiaryTag.findAll({ where: { id: tags } });
             await newNote.addTags(tagInstances);
+
+            const noteWithTags = await DiaryNote.findByPk(newNote.id, {
+                include: [{ model: DiaryTag, as: 'tags', required: false }],
+            });
+
+            return res.status(201).json(noteWithTags ?? newNote);
         }
 
-        const noteWithTags = await DiaryNote.findByPk(newNote.id, {
-            include: [{ model: DiaryTag, as: 'tags', required: false }],
-        });
-
-        res.status(201).json(noteWithTags ?? newNote);
+        res.status(201).json(newNote);
     } catch (error) {
+        console.error('[createNote] - Error:', error);
         res.status(500).json({ error: 'Error creating note' });
     }
 };

backend/controllers/memberNoteController.js

@@ -1,4 +1,5 @@
 import MemberNoteService from "../services/memberNoteService.js";
+import MemberNote from '../models/MemberNote.js';
 
 import { devLog } from '../utils/logger.js';
 const getMemberNotes = async (req, res) => {
@@ -21,6 +22,7 @@ const addMemberNote = async (req, res) => {
         const notes = await MemberNoteService.getNotesForMember(userToken, clubId, memberId);
         res.status(201).json(notes);
     } catch (error) {
+        console.error('[addMemberNote] - Error:', error);
         res.status(500).json({ error: 'systemerror' });
     }
 };
@@ -30,11 +32,16 @@ const deleteMemberNote = async (req, res) => {
         const { authcode: userToken } = req.headers;
         const { noteId } = req.params;
         const { clubId } = req.body;
-        const memberId = await MemberNoteService.getMemberIdForNote(noteId); // Member ID ermitteln
+        const note = await MemberNote.findByPk(noteId);
+        if (!note) {
+            return res.status(404).json({ error: 'notfound' });
+        }
+        const memberId = note.memberId;
         await MemberNoteService.deleteNoteForMember(userToken, clubId, noteId);
         const notes = await MemberNoteService.getNotesForMember(userToken, clubId, memberId);
         res.status(200).json(notes);
     } catch (error) {
+        console.error('[deleteMemberNote] - Error:', error);
         res.status(500).json({ error: 'systemerror' });
     }
 };

backend/controllers/myTischtennisUrlController.js

@@ -498,7 +498,7 @@ class MyTischtennisUrlController {
 
       const url = myTischtennisUrlParserService.buildUrl({
         association: team.league.association,
-        season: team.league.season.name,
+        season: team.league.season?.season,
         groupname: team.league.groupname,
         groupId: team.league.myTischtennisGroupId,
         teamId: team.myTischtennisTeamId,

backend/controllers/permissionController.js

@@ -69,6 +69,9 @@ export const updateUserRole = async (req, res) => {
     res.json(result);
   } catch (error) {
     console.error('Error updating user role:', error);
+    if (error.message && error.message.toLowerCase().includes('keine berechtigung')) {
+      return res.status(403).json({ error: error.message });
+    }
     res.status(400).json({ error: error.message });
   }
 };
@@ -92,6 +95,9 @@ export const updateUserPermissions = async (req, res) => {
     res.json(result);
   } catch (error) {
     console.error('Error updating user permissions:', error);
+    if (error.message && error.message.toLowerCase().includes('keine berechtigung')) {
+      return res.status(403).json({ error: error.message });
+    }
     res.status(400).json({ error: error.message });
   }
 };
@@ -141,6 +147,9 @@ export const updateUserStatus = async (req, res) => {
     res.json(result);
   } catch (error) {
     console.error('Error updating user status:', error);
+    if (error.message && error.message.toLowerCase().includes('keine berechtigung')) {
+      return res.status(403).json({ error: error.message });
+    }
     res.status(400).json({ error: error.message });
   }
 };

backend/controllers/teamDocumentController.js

@@ -29,15 +29,17 @@ const upload = multer({
     },
     fileFilter: (req, file, cb) => {
         // Erlaube nur PDF, DOC, DOCX, TXT, CSV Dateien
-        const allowedTypes = /pdf|doc|docx|txt|csv/;
-        const extname = allowedTypes.test(path.extname(file.originalname).toLowerCase());
-        const mimetype = allowedTypes.test(file.mimetype);
+        const allowedExtensions = ['.pdf', '.doc', '.docx', '.txt', '.csv'];
+        const allowedMimePatterns = ['pdf', 'msword', 'wordprocessingml.document', 'text/plain', 'csv', 'excel'];
 
-        if (mimetype && extname) {
+        const extensionValid = allowedExtensions.includes(path.extname(file.originalname).toLowerCase());
+        const mimetypeValid = allowedMimePatterns.some((pattern) => file.mimetype && file.mimetype.toLowerCase().includes(pattern));
+
+        if (extensionValid && mimetypeValid) {
             return cb(null, true);
-        } else {
-            cb(new Error('Nur PDF, DOC, DOCX, TXT und CSV Dateien sind erlaubt!'));
         }
+
+        cb(new Error('Nur PDF, DOC, DOCX, TXT und CSV Dateien sind erlaubt!'));
     }
 });