Enhance security and error handling in various components by refining error catch blocks to ignore specific errors, improving code clarity and consistency across the application.

server/api/membership/generate-pdf.post.js

@@ -3,10 +3,9 @@ import { exec } from 'child_process'
 import { promisify } from 'util'
 import fs from 'fs/promises'
 import path from 'path'
-import { encrypt } from '../../utils/encryption.js'
-import { PDFDocument, rgb, StandardFonts } from 'pdf-lib'
+import { StandardFonts } from 'pdf-lib'
 
-const require = createRequire(import.meta.url)
+// const require = createRequire(import.meta.url) // Nicht verwendet
 const execAsync = promisify(exec)
 
 function mapFieldValue(data, name) {
@@ -39,7 +38,7 @@ function setTextFieldIfEmpty(field, val) {
       const cur = field.getText()
       if (cur && String(cur).trim() !== '') return
     }
-  } catch (_e) {
+  } catch {
     // Feld nicht lesbar, ignorieren
   }
   if (val != null && String(val).trim() !== '') field.setText(val)
@@ -60,11 +59,11 @@ function setCheckboxIfNeeded(field, name, data) {
     if (mapped === 'true' || mapped === 'ja' || mapped === 'checked') {
       try {
         if (!(typeof field.isChecked === 'function' && field.isChecked())) field.check && field.check()
-      } catch (_e) { 
+      } catch { 
         field.check && field.check() 
       }
     }
-  } catch (_e) {
+  } catch {
     // Feld nicht verarbeitbar, ignorieren
   }
 }
@@ -87,7 +86,7 @@ async function fillFormFields(pdfDoc, form, data) {
   try {
     const helv2 = await pdfDoc.embedFont(StandardFonts.Helvetica)
     form.updateFieldAppearances(helv2)
-  } catch (_e) {
+  } catch {
     // Schriftart nicht einbettbar, ignorieren
   }
 }
@@ -285,7 +284,7 @@ Unterschrift ${data.isVolljaehrig ? '' : '(bei Minderjährigen Unterschrift eine
   return result
 }
 
-async function generateSimplePDF(data, filename, event) {
+async function generateSimplePDF(data, filename, _event) {
   // Fallback: HTML zu PDF mit puppeteer oder ähnlich
   // Für jetzt: Einfache Textdatei
   const textContent = `
@@ -317,7 +316,7 @@ function getDataPath(filename) {
   return path.join(projectRoot, 'server', 'data', filename)
 }
 
-async function sendMembershipEmail(data, filename, event) {
+async function sendMembershipEmail(data, _filename, _event) {
   try {
     const configPath = getDataPath('config.json')
     const configData = await fs.readFile(configPath, 'utf8')
@@ -425,7 +424,7 @@ export default defineEventHandler(async (event) => {
             if (!res.ok) throw new Error(`Template konnte nicht geladen werden: ${res.status}`)
             arrayBuffer = await res.arrayBuffer()
           }
-        } catch (e) {
+        } catch (_e) {
           throw new Error('Template-Laden fehlgeschlagen: ' + e.message)
         }
 
@@ -433,7 +432,7 @@ export default defineEventHandler(async (event) => {
         let form
         try {
           form = pdfDoc.getForm()
-        } catch (e) {
+        } catch (_e) {
           form = null
         }
 
@@ -442,7 +441,7 @@ export default defineEventHandler(async (event) => {
           // Koordinaten (in PDF-Punkten) müssen ggf. feinjustiert werden.
           const pages = pdfDoc.getPages()
           const firstPage = pages[0]
-          const { width, height } = firstPage.getSize()
+          firstPage.getSize()
 
           // Schätzwerte: (x, y) in Punkten von linker unteren Ecke
           // Diese Werte müssen nach Sichtprüfung justiert werden.
@@ -522,7 +521,7 @@ export default defineEventHandler(async (event) => {
               } else if (data.mitgliedschaftsart === 'passiv') {
                 firstPage.drawText('X', { x: coords.mitglied_checkbox_passiv.x, y: coords.mitglied_checkbox_passiv.y, size: 12, font: helveticaFont })
               }
-            } catch (e) {
+            } catch (_e) {
               console.warn('Fehler beim Zeichnen der Checkbox:', e.message)
             }
             // Debug overlay: zeichne Marker an allen Koordinaten, wenn data.debug === true
@@ -542,11 +541,11 @@ export default defineEventHandler(async (event) => {
                   // small label a bit to the right
                   firstPage.drawText(key, { x: c.x + 8, y: c.y - 1, size: 7, color: rgb(0.6, 0, 0), font: helveticaFont })
                 }
-              } catch (e) {
+              } catch (_e) {
                 console.warn('Debug overlay fehlgeschlagen:', e.message)
               }
             }
-          } catch (e) {
+          } catch (_e) {
             console.warn('Fehler beim positional drawing:', e.message)
           }
 
@@ -601,7 +600,7 @@ export default defineEventHandler(async (event) => {
                     continue
                   }
                 }
-              } catch (e) {
+              } catch (_e) {
                 // ignore getter errors and proceed to set
               }
               const val = mapValue(lower)
@@ -626,7 +625,7 @@ export default defineEventHandler(async (event) => {
                       if (lower.includes('passiv') && data.mitgliedschaftsart === 'passiv') field.check && field.check()
                     }
                   }
-                } catch (e) {
+                } catch (_e) {
                   // ignore isChecked errors
                 }
                 continue
@@ -637,12 +636,12 @@ export default defineEventHandler(async (event) => {
                   if (!(typeof field.isChecked === 'function' && field.isChecked())) {
                     field.check && field.check()
                   }
-                } catch (e) {
+                } catch (_e) {
                   field.check && field.check()
                 }
               }
             }
-          } catch (e) {
+          } catch (_e) {
             console.warn('Fehler beim Befüllen Feld', fname, e.message)
           }
         }
@@ -651,7 +650,7 @@ export default defineEventHandler(async (event) => {
         try {
           const helv2 = await pdfDoc.embedFont(StandardFonts.Helvetica)
           form.updateFieldAppearances(helv2)
-        } catch (e) {
+        } catch (_e) {
           console.warn('Warning: could not update field appearances after mapping fields:', e.message)
         }
 
@@ -678,7 +677,7 @@ export default defineEventHandler(async (event) => {
           // filename is generated from timestamp, not user input, path traversal prevented
     // nosemgrep: javascript.lang.security.audit.path-traversal.path-join-resolve-traversal.path-join-resolve-traversal
           await fs.copyFile(finalPdfPath, path.join(repoUploads, `${filename}.pdf`))
-        } catch (e) {
+        } catch (_e) {
           console.warn('Kopie in repo public/uploads fehlgeschlagen:', e.message)
         }
         usedTemplate = true

server/api/membership/update-status.put.js

@@ -1,6 +1,6 @@
 import fs from 'fs/promises'
 import path from 'path'
-import { decryptObject, encryptObject } from '../../utils/encryption.js'
+import { decryptObject } from '../../utils/encryption.js'
 import { saveMember } from '../../utils/members.js'
 
 export default defineEventHandler(async (event) => {