torsten/harheimertc
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor authentication logic in members API to use getUserFromToken for user retrieval. Update error messages for better clarity and enhance tests to reflect changes in authentication handling.
Some checks failed
Code Analysis (JS/Vue) / analyze (push) Failing after 1m2s
Details

Browse Source
This commit is contained in:
Torsten Schulz (local)
2026-03-30 15:29:25 +02:00
parent 7dea265eef
commit 5eee7df7e4
2 changed files with 16 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
tests/members-endpoints.spec.ts
View File

@@ -114,8 +114,7 @@ describe('Members API Endpoints', () => {
it('verlangt Admin- oder Vorstand-Rolle', async () => {
const event = createEvent({ cookies: { auth_token: 'token' } })
mockSuccessReadBody(baseBody)
authUtils.verifyToken.mockReturnValue({ id: '2' })
authUtils.getUserById.mockResolvedValue({ id: '2', role: 'mitglied' })
authUtils.getUserFromToken.mockResolvedValue({ id: '2', role: 'mitglied' })
await expect(membersPostHandler(event)).rejects.toMatchObject({ statusCode: 403 })
})
@@ -123,8 +122,7 @@ describe('Members API Endpoints', () => {
it('gibt 409 bei Duplikaten zurück', async () => {
const event = createEvent({ cookies: { auth_token: 'token' } })
mockSuccessReadBody(baseBody)
authUtils.verifyToken.mockReturnValue({ id: '2' })
authUtils.getUserById.mockResolvedValue({ id: '2', role: 'admin' })
authUtils.getUserFromToken.mockResolvedValue({ id: '2', role: 'admin' })
memberUtils.saveMember.mockRejectedValue(new Error('existiert bereits'))
await expect(membersPostHandler(event)).rejects.toMatchObject({ statusCode: 409 })
@@ -133,8 +131,7 @@ describe('Members API Endpoints', () => {
it('speichert Mitglied erfolgreich', async () => {
const event = createEvent({ cookies: { auth_token: 'token' } })
mockSuccessReadBody(baseBody)
authUtils.verifyToken.mockReturnValue({ id: '2' })
authUtils.getUserById.mockResolvedValue({ id: '2', role: 'admin' })
authUtils.getUserFromToken.mockResolvedValue({ id: '2', role: 'admin' })
memberUtils.saveMember.mockResolvedValue(true)
const response = await membersPostHandler(event)
@@ -143,6 +140,16 @@ describe('Members API Endpoints', () => {
hasHallKey: true
}))
})
it('erlaubt vorstand beim Speichern', async () => {
const event = createEvent({ cookies: { auth_token: 'token' } })
mockSuccessReadBody(baseBody)
authUtils.getUserFromToken.mockResolvedValue({ id: '3', role: 'vorstand' })
memberUtils.saveMember.mockResolvedValue(true)
const response = await membersPostHandler(event)
expect(response.success).toBe(true)
})
})
describe('DELETE /api/members', () => {